Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Dependency updates #4975

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Dev Dependency updates #4975

merged 6 commits into from
Dec 19, 2019

Conversation

amywalkerdev
Copy link
Contributor

@amywalkerdev amywalkerdev commented Dec 17, 2019

Overall change:
Updates a number of dev dependencies, covers #4956 #4957 #4960 #4961 #4963 #4964

Code changes:

  • Bumps the version number for dev dependencies in package.json and package-lock.json

  • I have assigned myself to this PR and the corresponding issues
  • I have added labels to this PR for the relevant pod(s) affected by these changes
  • I have assigned this PR to the Simorgh project

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)
  • This PR requires manual testing

@amywalkerdev amywalkerdev added ws-articles Tasks for the WS Articles Team simorgh-core-stream shared-components ws-media World Service Media labels Dec 17, 2019
@amywalkerdev amywalkerdev self-assigned this Dec 17, 2019
@amywalkerdev
Copy link
Contributor Author

eslint-plugin-import is not playing nicely 😠

@amywalkerdev
Copy link
Contributor Author

eslint-plugin-import has a bug which is flagging import extensions: import-js/eslint-plugin-import#1573

Going to keep it at the last version until they release their update with a fix.

@amywalkerdev amywalkerdev merged commit 985329e into latest Dec 19, 2019
@amywalkerdev amywalkerdev deleted the dev-dep-updates branch December 19, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shared-components ws-articles Tasks for the WS Articles Team ws-media World Service Media
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants