Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: improve sw caching #12546

Draft
wants to merge 4 commits into
base: latest
Choose a base branch
from
Draft

spike: improve sw caching #12546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec1aebe
ENH: improve sw caching
eagerterrier Mar 22, 2025
a45693b
ENH: better pattern matching
eagerterrier Mar 22, 2025
eb83cfb
Merge branch 'latest' into features/sw-improve-caching
eagerterrier Mar 22, 2025
45bb969
FIX: version and hash
eagerterrier Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions public/sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
/* eslint-disable no-unused-vars */
/* eslint-disable no-undef */
/* eslint-disable no-restricted-globals */
const version = 'v0.2.2';
const version = 'v0.2.3';
const cacheName = 'simorghCache_v1';

const service = self.location.pathname.split('/')[1];
Expand All @@ -17,6 +17,13 @@ self.addEventListener('install', event => {
});
});

// versioned JS files
const cacheableFiles = [
'https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/reverb-3.9.2.js',
'https://mybbc-analytics.files.bbci.co.uk/reverb-client-js/smarttag-5.29.4.min.js'
];


const fetchEventHandler = async event => {
if (
/^https:\/\/ichef(\.test)?\.bbci\.co\.uk\/(news|images|ace\/(standard|ws))\/.+.webp$/.test(
Expand All @@ -42,10 +49,14 @@ const fetchEventHandler = async event => {
);
}
} else if (
self.location.hostname !== 'localhost' &&
/((\/cwr\.js$)|(\.woff2$)|(modern\.frosted_promo+.*?\.js$)|(\/moment-lib+.*?\.js$))/.test(
event.request.url,
(
event.request.url.indexOf('https://static.files.bbci.co.uk/') === 0 &&
/((\.woff2$)|(modern\.frosted_promo+.*?\.js$)|(\/moment-lib+.*?\.js$)|(\/images\/icons\/icon-.*?\.png$))/.test(
event.request.url,
)
)
||
cacheableFiles.includes(event.request.url)
) {
event.respondWith(
(async () => {
Expand Down
4 changes: 2 additions & 2 deletions src/sw.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ describe('Service Worker', () => {

describe('version', () => {
const CURRENT_VERSION = {
number: 'v0.2.2',
fileContentHash: '3526df1507b20c47700339c8d7eb6c83',
number: 'v0.2.3',
fileContentHash: '6e748772bde8e432c170da9b26f7a7f1',
};

it(`version number should be ${CURRENT_VERSION.number}`, async () => {
Expand Down
Loading