-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORLDSERVICE-112 - Optimizely set-up for Top Bar OJ experiment #12529
WORLDSERVICE-112 - Optimizely set-up for Top Bar OJ experiment #12529
Conversation
…nt' of github.com:bbc/simorgh into WORLDSERVICE-112-optimizely-set-up-for-top-bar-experiment
…nt' of github.com:bbc/simorgh into WORLDSERVICE-112-optimizely-set-up-for-top-bar-experiment
@louisearchibald To test the variations, you can use the ModHeader extension in Chrome and set a new Request Header to: It needs the Once you do that, if you resize your window down you should then see the top bar OJ. |
…nt' of github.com:bbc/simorgh into WORLDSERVICE-112-optimizely-set-up-for-top-bar-experiment
Looks great! Could you add in a check that the
So something like:
I got an error that |
Realised as well we'll need to pass in simorgh/src/app/legacy/components/ScrollablePromo/index.jsx Lines 155 to 160 in 6292deb
You can grab it from the |
…nt' of github.com:bbc/simorgh into WORLDSERVICE-112-optimizely-set-up-for-top-bar-experiment
Resolves JIRA [112]
Overall changes
Implementing the set-up required to run the server-side Optimizely Top Bar OJ experiment.
Code changes
isClientSide
to betrue
inside of theuseOptimizelyVariation
hook.ScrollablePromo
component andArticlePage
.enabledExperimentList
with correct key name of the experiment and adds the services it will be rolled out to to the services array.