Upgrade Puppeteer to 24.4.0 #12524
Open
Upgrade Puppeteer to 24.4.0 #12524
+622
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinathomasbbc
commented
Mar 18, 2025
There was a problem hiding this comment.
Assertions taken from the original puppeteer/bundleRequests.test.js -> https://github.com/bbc/simorgh/blob/aeaa4b72825b8205645e45e6165cd907ccc440d8/puppeteer/bundleRequests.test.js
karinathomasbbc
changed the title
karinathomasbbc
force-pushed
the
upgrade-puppeteer
branch
from
a40ee59 to
213da35
Compare
amoore108
approved these changes
Mar 24, 2025
eagerterrier
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall changes
Upgrades puppeteer to the latest version & refactors bundle request test to use new puppeteer test runner
Code changes
Testing