Refactor and adaptive progress bar #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emettely
commented
Mar 26, 2020
Comment on lines
+26
to
+30
| useEffect(() => { | ||
| if (offsetWidth !== width) { | ||
| setWidth(offsetWidth); | ||
| } | ||
| }, [ ref ]); | ||
| }, [ offsetWidth ]); |
There was a problem hiding this comment.
No need to use Layout Effect. useEffect does not work very well with ref changes, as objects make it more difficult to detect changes.
Comment on lines
+8
to
+11
| const secondsToHHMMSSFormat = (seconds) => { | ||
| return new Date(seconds * 1000).toISOString().substr(11, 8); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Moving it out of main component as it's a very generic function. Could be moved to a util file.
| @@ -1,71 +1,66 @@ | |||
| import React, { Component } from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
General refactor to move to a function based component.
Comment on lines
+57
to
+64
| ProgrammeScriptEditor.propTypes = { | ||
| handleDelete: PropTypes.any, | ||
| handleEdit: PropTypes.any, | ||
| handleReorder: PropTypes.any, | ||
| items: PropTypes.any, | ||
| playlist: PropTypes.any, | ||
| title: PropTypes.any | ||
| }; |
|
|
||
| export default ProgramScript; | ||
| export default ProgrammeScriptEditor; |
There was a problem hiding this comment.
renamed, as it was being imported as ProgrammeScriptEditor
| @@ -3,7 +3,6 @@ import React from 'react'; | |||
| import { storiesOf } from '@storybook/react'; | |||
| import { action } from '@storybook/addon-actions'; | |||
| import ProgrammeScriptEditor from '../index.js'; | |||
| import PreviewCanvas from '../../PreviewCanvas'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Fixes #40
Describe what the PR does
See below in comments:
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context
Post review tasks
release