Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i45, related to #45 #46

Merged
merged 15 commits into from
Mar 26, 2020
Merged

i45, related to #45 #46

merged 15 commits into from
Mar 26, 2020

Conversation

emettely
Copy link
Contributor

@emettely emettely commented Mar 24, 2020

Is your Pull Request request related to another issue in this repository ?

Fixes #45

Describe what the PR does
#45

State whether the PR is ready for review or whether it needs extra work
Ready

Additional context

@emettely emettely added this to the CI / CD milestone Mar 24, 2020
@emettely emettely changed the title Adding travis YML and updating package.json with public Config i45, related to #45 Mar 25, 2020
@emettely emettely requested a review from allishultes March 25, 2020 08:56
Copy link
Contributor Author

@emettely emettely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added Travis config using personal NPM credentials due to licensing issues.
  • Updated document about deployment
  • Cleaned up Jest and replaced Enzyme (which provided snapshots) with RTL. Tests implementation tbd. Would be nice to have tests eventually.

@emettely emettely merged commit aab9535 into master Mar 26, 2020
@emettely emettely deleted the i45 branch March 26, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Travis CI to deploy to NPM
2 participants