Fixed the actions not appearing for Cards #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emettely
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Making sure that the changes will work for the npm refactor.
The parent's passing in the functions were not actually being used. So when passing in functions to delete a Transcript for example would not do anything.
Describe what the PR does
Removes binding to the children components, in order to use the right functions.
Will re-publish to NPM and gh pages after
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context
Apparently arrow functions are not great for performance as it creates a new function every time, although not related to how it wasn't actually using the parent's arrow function.