Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI demo type components: workspace view and itemscontainer #32

Merged
merged 14 commits into from
Oct 12, 2019

Conversation

emettely
Copy link
Contributor

@emettely emettely commented Oct 12, 2019

Is your Pull Request request related to another issue in this repository ?
bbc/digital-paper-edit-client#60
Adding a demo component for easy view of different UI flows.
It may not fully work yet, but as these are demo components (not published in NPM, thought it be best to merge them now as git books is already using this branch)

Describe what the PR does

  • Changes to some parts of the tests, want it to be more explicit with arguments.
  • Reformatting of markdown files
  • Fixing bugs in item form, where descriptions etc were not updating
  • Fixing bugs in List where items were not showing up (follow up work needs to happen on cards)
  • extracting out search bar for more easy componentialising
  • massive fix in being able to publish to NPM - see doc in changes.

State whether the PR is ready for review or whether it needs extra work
Ready, (with problems)

Additional context

@emettely emettely changed the title Other UI demo type components, such as workspace view and itemscontainer UI demo type components: workspace view and itemscontainer Oct 12, 2019
@emettely emettely merged commit 5a82cb9 into master Oct 12, 2019
@emettely emettely deleted the PageViewComponent branch October 12, 2019 07:22
@emettely emettely added bug Something isn't working documentation Changes only affect the documentation enhancement New feature or request Feature A component and/or new feature labels Oct 12, 2019
@emettely emettely self-assigned this Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Changes only affect the documentation enhancement New feature or request Feature A component and/or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant