Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds custom breadcrumb component #19

Merged
merged 3 commits into from
Sep 6, 2019
Merged

Conversation

allishultes
Copy link
Contributor

Is your Pull Request request related to another issue in this repository ?

Issue #8

Describe what the PR does

Adds and hook-ifies the CustomBreadcrumb component from DPE Client.

State whether the PR is ready for review or whether it needs extra work

Ready for review.

Additional context

@allishultes allishultes requested a review from emettely September 2, 2019 16:22
@allishultes allishultes added the generic component A non-workspace component for the storybook label Sep 2, 2019
Copy link
Contributor

@emettely emettely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a few reading tweaks :)

@allishultes allishultes merged commit 94cece9 into master Sep 6, 2019
@allishultes allishultes deleted the adds-breadcrumb-component branch September 6, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic component A non-workspace component for the storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants