Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmescript #18

Merged
merged 28 commits into from
Sep 12, 2019
Merged

Programmescript #18

merged 28 commits into from
Sep 12, 2019

Conversation

emettely
Copy link
Contributor

@emettely emettely commented Sep 2, 2019

Is your Pull Request request related to another issue in this repository ?

https://github.com/bbc/digital-paper-edit-client/issues/51

Describe what the PR does
Refactors and extracts out the Programme Script.

State whether the PR is ready for review or whether it needs extra work
Ready

Additional context
Breaking down big components in programme script.
Adding them to the storybook.

Copy link
Contributor

@allishultes allishultes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) Just a few small things re: code comments, Bootstrap classes. I was wondering why / whether the programme script should be able to handle edits and deletes? Is there a wrapper element that's going to handle that instead / talks to apis?

@emettely
Copy link
Contributor Author

Looks good :) Just a few small things re: code comments, Bootstrap classes. I was wondering why / whether the programme script should be able to handle edits and deletes? Is there a wrapper element that's going to handle that instead / talks to apis?

You're probably right in saying that the Programme Script Container should be the one to decide what the handleEdit + handleDelete should be, but I hadn't broken down the ProgrammeScriptContainer enough to do that. If I had the ProgrammeElements as an individual story, that's probably what I would have done, but I didn't want to get too far refactoring.

@emettely emettely merged commit 9d950c2 into master Sep 12, 2019
@emettely emettely deleted the programmescript branch September 12, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants