-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programmescript #18
Programmescript #18
Conversation
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/stories/index.stories.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) Just a few small things re: code comments, Bootstrap classes. I was wondering why / whether the programme script should be able to handle edits and deletes? Is there a wrapper element that's going to handle that instead / talks to apis?
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/SortableItem.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/SortableItem.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/SortableItem.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/SortableItem.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/index.js
Outdated
Show resolved
Hide resolved
…/PaperCut.js Co-Authored-By: Alli Shultes <[email protected]>
…/PaperCut.js Co-Authored-By: Alli Shultes <[email protected]>
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Outdated
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Show resolved
Hide resolved
packages/components/ProgrammeScriptContainer/ProgrammeElements/PaperCut.js
Show resolved
Hide resolved
…/index.js Co-Authored-By: Alli Shultes <[email protected]>
…/SortableItem.js Co-Authored-By: Alli Shultes <[email protected]>
…/SortableItem.js Co-Authored-By: Alli Shultes <[email protected]>
…/SortableItem.js Co-Authored-By: Alli Shultes <[email protected]>
…/SortableItem.js Co-Authored-By: Alli Shultes <[email protected]>
You're probably right in saying that the Programme Script Container should be the one to decide what the handleEdit + handleDelete should be, but I hadn't broken down the ProgrammeScriptContainer enough to do that. If I had the ProgrammeElements as an individual story, that's probably what I would have done, but I didn't want to get too far refactoring. |
Is your Pull Request request related to another issue in this repository ?
https://github.com/bbc/digital-paper-edit-client/issues/51
Describe what the PR does
Refactors and extracts out the Programme Script.
State whether the PR is ready for review or whether it needs extra work
Ready
Additional context
Breaking down big components in programme script.
Adding them to the storybook.