Item form modal #17
Merged
Item form modal #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allishultes
added
the
generic component
emettely
suggested changes
Sep 6, 2019
Co-Authored-By: Eimi Okuno <[email protected]>
Co-Authored-By: Eimi Okuno <[email protected]>
Co-Authored-By: Eimi Okuno <[email protected]>
Co-Authored-By: Eimi Okuno <[email protected]>
Co-Authored-By: Eimi Okuno <[email protected]>
emettely
suggested changes
Sep 9, 2019
| const editedProject = { | ||
| title: title, | ||
| description: description, | ||
| id: props.id | ||
| }; | ||
|
|
||
| props.handleSaveForm(editedProject); | ||
| } | ||
| } else if (!isValidated) { | ||
| setIsValidated(true); |
There was a problem hiding this comment.
setIsValidated(true); needs to happen for both cases - see line 20 + 24 in the previous version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Issue #7
Issue #10
Describe what the PR does
Adds the ItemForm and FormModal components to the Storybook. Both have been refactored using React Hooks.
The ItemForm has one story:
Edit Project. It:The ItemFormModal component has two stories:
Edit ProjectandNew Project. TheEdit Projectstory includes an ItemForm component that is passed a title, description and id from the FormModal component. TheNew Projectstory does not pas ItemForm an id, title or description. In both cases, the modal:The PR also changes the folder structure for the List and Search Bar components for kicks and giggles.
State whether the PR is ready for review or whether it needs extra work
Almost ready for review (where does the new project id come from?).
Additional context