Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds transcript card #16

Merged
merged 6 commits into from
Sep 9, 2019
Merged

Adds transcript card #16

merged 6 commits into from
Sep 9, 2019

Conversation

allishultes
Copy link
Contributor

@allishultes allishultes commented Aug 30, 2019

Is your Pull Request request related to another issue in this repository ?

Issue #4
Issue #11

Describe what the PR does

  • Adds a separate component for Transcript Cards
    Within the scope of the Simple Card component (see issue above), it was left to the engineer to determine whether a single card component could satisfy requirements for both the project / paper edit cards, and the transcript cards. From looking at the code base, I do think it would be too messy to include that conditional handling in the same file.

In addition to the functionality in the SimpleCard component, the Transcript Card component includes:

  • A status badge beneath the transcript description
  • A status button to the right of the delete button
  • Disables the title hyperlink to transcripts with a status of 'in progress' or 'error'

Additional work on this PR:

  • Refactors TranscriptCard to be a functional component, from the original code.
  • Adds conditional handling to the List component to be able to handle both Simple Cards and Transcript Cards. (Right now, this is relying on a status field being in the transcription data. We might want to consider refactoring the data to give it a type field or something more explicit).

State whether the PR is ready for review or whether it needs extra work

Ready for review.

Additional context

@allishultes allishultes requested a review from emettely August 30, 2019 16:57
@allishultes allishultes added the generic component A non-workspace component for the storybook label Aug 30, 2019
packages/components/List/index.js Outdated Show resolved Hide resolved
packages/components/List/index.js Show resolved Hide resolved
packages/components/TranscriptCard/index.js Show resolved Hide resolved
packages/components/TranscriptCard/index.js Outdated Show resolved Hide resolved
packages/components/TranscriptCard/index.js Outdated Show resolved Hide resolved
@allishultes allishultes merged commit 7199e22 into master Sep 9, 2019
@allishultes allishultes deleted the adds-transcript-card branch September 9, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic component A non-workspace component for the storybook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants