-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds list component #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional feedback from Slack:
Running the storybook
- I'm not sure if the description should be clickable in the card (not part of this list component)
- Wonder if the Cards should be inside the List in the Storybook
- Search isn't in the List component in the Storybook, is this expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional review, sorry it's not in one go.
|
Is your Pull Request request related to another issue in this repository ?
Issue: https://github.com/orgs/bbc/projects/42#card-25190014
Describe what the PR does
Adds a list component that displays SimpleCard components and filters the components with a search bar.
showLinkPath
function).State whether the PR is ready for review or whether it needs extra work
The PR is ready for review — but I think this branch might need to be revisited in the future to handle editing and deleting of cards. Currently, this is performed at the page level in DPE-client because it involves interacting with the API Wrapper. However, it seems like we should be able to handle deletes from a list.
Additional context