-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple card #12
Simple card #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly cool, more to refactor but at a later stage.
} | ||
|
||
showLinkPath = () => { | ||
return this.props.showLinkPath(this.props.id) || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth implementing a refactor to simplify the logic later on when you are working on the List
.
showLinkPath
shouldn't be passed on here as it over-complicates things.
to
functionality in the LinkContainer should be taking in string
of a url - and redirecting to that. Not taking in a showLinkPath
function.
Co-Authored-By: Eimi Okuno <[email protected]>
Co-Authored-By: Eimi Okuno <[email protected]>
Is your Pull Request request related to another issue in this repository ?
Issue: https://github.com/orgs/bbc/projects/42#card-25230949
Describe what the PR does
Adds SimpleCard component to the Storybook.
Includes:
Unknowns:
State whether the PR is ready for review or whether it needs extra work
Ready for review and feedback please :)
Additional context