Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.mill as a project file name for the mill project type #1930

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

LaurenceWarne
Copy link
Contributor

@LaurenceWarne LaurenceWarne commented Feb 13, 2025

Hi, this PR adds build.mill as a project file name for the mill project type, it seems to be the recommended extension now, see https://mill-build.org/mill/scalalib/intro.html.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the docs (when adding new project types, configuration options, commands, etc)

Thanks!

Add build.mill as a project file name for the mill project type, it
seems to be the recommended extension now, see https://mill-build.org/mill/scalalib/intro.html.
(projectile-register-project-type 'mill '("build.sc")
:project-file "build.sc"
(projectile-register-project-type 'mill #'projectile-mill-project-p
:project-file '("build.sc" "build.mill")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this require some code changes or it was already accounted for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in allowing lists? - If so I believe it should already be accounted for:

(project-files (if (listp project-file)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. I just noticed you updated the docstrings, but there were no other changes, so it seemed prudent to ask about this. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeap, probably should have pointed that out, sorry!

@bbatsov bbatsov merged commit 827fa65 into bbatsov:master Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants