Skip to content

open-fdd-nf export-folder: one equipment as an SI device folder (#1653) - #1690

Open
bbartling wants to merge 1 commit into
release/5.0.21from
grok/1653-nf-export-folder
Open

bbartling wants to merge 1 commit into
release/5.0.21from
grok/1653-nf-export-folder

Conversation

@bbartling

Copy link
Copy Markdown
Owner

Standalone on release/5.0.21 (not stacked). Refs #1653, #1663.

Change

open-fdd-nf export-folder --equip REF [--site S] --days N --out DIR (or --start/--end, --window, default 300 s):

  • Reuses equipment_frames: NF point/data resampled to the window, roles bound from the model, and the app's SI plan (si_plan_for). No new unit table and no guessing.
  • Writes DIR/history_wide.csv (timestamp_utc + Haystack role columns, SI).
  • Writes DIR/column_map.json:
    • equipType stamp, so the AHU-only loaders admit it
    • points, units, bindings (role, name, unit, source_unit, class)
    • skipped, unit_unverified (no unit or a unit outside the SI table, kept as stored), unmapped_points
    • range and window_sec
  • Fails loudly: if a bound point's unit cannot be converted, the export stops with exit 2 and writes nothing. --allow-skips exports the rest and lists them. An unknown --equip, an ambiguous one (the same id on two sites) or a missing one is an error that names the choices.
  • New module open_fdd/nf/device_folder.py, a row in docs/pypi-agent-tools.md, and tests/test_nf_export_folder.py (4 tests, mock NF).

Evidence (mock NF, frozen clock 2026-11-18 20:00 UTC, 2-day window)

  • I exported all 16 mock equipment. 15 exported (577 rows each, e.g. AHU-1 has 14 roles and 9 unmapped points). CT-1 stopped: fan_cmd and tower_fan_cmd are fractions with no unit, so 0-100 vs 0-1 can't be told apart.
  • The AHU-1 folder's discharge-air-temp equals equipment_frames (max abs diff < 1e-9), °F → °C. Static pressure is in Pa and the damper is a fraction.
  • That folder runs unchanged through:
    • open-fdd-anomaly screen --methods zscore,mad: exit 0, scoreboard written
    • open-fdd-ml detect --method pca --train-until ...: 577 rows, 7 roles, top contributors reported
  • Local: tests/test_nf_export_folder.py + tests/test_open_fdd_nf.py, 45 passed.

…der (#1653)

Reuses equipment_frames (NF point/data at --window, model role binding, the app's SI plan) and writes
history_wide.csv (timestamp_utc + role columns) and column_map.json (equipType stamp, points, units, bindings,
skipped, unit_unverified, unmapped_points, range). A bound point whose unit cannot be converted stops the export
and writes nothing unless --allow-skips; ambiguous or unknown --equip is an error naming the choices.
Tested against the mock NF: AHU-1 values equal equipment_frames and load_device_folder admits the AHU;
CT-1 (unit-less fraction commands) fails loudly, then exports with --allow-skips.

Refs #1653, #1663
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dea93258-8427-4063-99b1-d43a2360530c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant