Repository navigation
Conversation
…der (#1653) Reuses equipment_frames (NF point/data at --window, model role binding, the app's SI plan) and writes history_wide.csv (timestamp_utc + role columns) and column_map.json (equipType stamp, points, units, bindings, skipped, unit_unverified, unmapped_points, range). A bound point whose unit cannot be converted stops the export and writes nothing unless --allow-skips; ambiguous or unknown --equip is an error naming the choices. Tested against the mock NF: AHU-1 values equal equipment_frames and load_device_folder admits the AHU; CT-1 (unit-less fraction commands) fails loudly, then exports with --allow-skips. Refs #1653, #1663
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone on
release/5.0.21(not stacked). Refs #1653, #1663.Change
open-fdd-nf export-folder --equip REF [--site S] --days N --out DIR(or--start/--end,--window, default 300 s):equipment_frames: NFpoint/dataresampled to the window, roles bound from the model, and the app's SI plan (si_plan_for). No new unit table and no guessing.DIR/history_wide.csv(timestamp_utc+ Haystack role columns, SI).DIR/column_map.json:equipTypestamp, so the AHU-only loaders admit itpoints,units,bindings(role, name, unit, source_unit, class)skipped,unit_unverified(no unit or a unit outside the SI table, kept as stored),unmapped_pointswindow_sec--allow-skipsexports the rest and lists them. An unknown--equip, an ambiguous one (the same id on two sites) or a missing one is an error that names the choices.open_fdd/nf/device_folder.py, a row indocs/pypi-agent-tools.md, andtests/test_nf_export_folder.py(4 tests, mock NF).Evidence (mock NF, frozen clock 2026-11-18 20:00 UTC, 2-day window)
fan_cmdandtower_fan_cmdare fractions with no unit, so 0-100 vs 0-1 can't be told apart.discharge-air-tempequalsequipment_frames(max abs diff < 1e-9), °F → °C. Static pressure is in Pa and the damper is a fraction.open-fdd-anomaly screen --methods zscore,mad: exit 0, scoreboard writtenopen-fdd-ml detect --method pca --train-until ...: 577 rows, 7 roles, top contributors reportedtests/test_nf_export_folder.py+tests/test_open_fdd_nf.py, 45 passed.