Fixed issue #122 - Session ignores deserializer json #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the zlib compression of json
|
thanks for catching this, looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittest using the file namespace manager also provided. I haven't run tests for mongodb and all combinations of other drivers so I'm assuming they will run based on the fact that it's a base64 encoded string and everyone should be able to insert a string.
This commit will likely invalidate all sessions once deployed due to the fact that all sessions now get base64 encoded when written in storage (and decoded back) vs the previous situation of only encrypted sessions getting base64 encoded.