Skip to content

Commit

Permalink
fix: exclude build products under template from packaging
Browse files Browse the repository at this point in the history
`.gitignore` was ignoring some items under template that still appeared in the packaged releases,
because `template` was explicitly included in package.json, and that overrides those ignores.

Adding explicit exclusions for the build products under `template` to `package.json` prevents
packaging errors.

I've added `template/elm-stuff` and `template/index.html` to `.gitignore` too, because those
are created if `elm make src/Main.elm` is run in `template`, which seems to have been the cause.

re halfzebra#275
  • Loading branch information
bazzargh committed Sep 3, 2018
1 parent 06ad2d8 commit fc1189c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ repl-temp-*

# create-elm-app
template/build
template/elm-stuff
template/index.html
template/package.json
template/scripts/
template/config/
Expand Down
8 changes: 7 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,13 @@
"config",
"scripts",
"template",
"README.md"
"README.md",
"!template/build",
"!template/config/",
"!template/elm-stuff/",
"!template/index.html",
"!template/package.json",
"!template/scripts/"
],
"keywords": [
"cli",
Expand Down

0 comments on commit fc1189c

Please sign in to comment.