Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiprocessing in Makefiles #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OPNA2608
Copy link

@OPNA2608 OPNA2608 commented Dec 1, 2020

Fixes make's self-identification of recursive make calls in rules, required to fix multiprocessing (invoking make with e.g. -j2).

Warning when attempting to run e.g. make -j2 on v0.2.0 (middle of execution):

make -C snes_driver
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.

See GNU make Error Message, Section "warning: jobserver unavailable: using -j1. Add `+' to parent make rule." and How the MAKE Variable Works.

Build time measurements via time:

unfixed, -j1
real 1m36,646s
user 1m20,740s
sys 0m15,071s

unfixed, -j6 (ignored by recursive make invocations, essentially -j1)
real 1m35,451s
user 1m19,411s
sys 0m15,300s

fixed, -j6
real 0m24,334s
user 1m48,657s
sys 0m19,671s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant