Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge MethodSignatureProcessor into JarTransformerChain #30

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 8, 2023

Before this commit, all class files were parsed twice.

This change results in a ~8% decrease in average runtime on the JUnit benchmark.

Before this commit, all class files were parsed twice.

This change results in a ~10% decrease in average runtime on the JUnit
benchmark.
@fmeum fmeum force-pushed the inline-method-rewriter branch from 08a1569 to 741e8ea Compare January 8, 2023 14:06
@fmeum fmeum marked this pull request as ready for review January 8, 2023 14:59
@johnynek
Copy link
Collaborator

thanks! 8% is meaningful

@johnynek johnynek merged commit 61aa594 into bazeltools:master Jan 20, 2023
@fmeum fmeum deleted the inline-method-rewriter branch January 21, 2023 23:17
@fmeum
Copy link
Contributor Author

fmeum commented Jan 21, 2023

@johnynek Thanks for the reviews. Could you maybe tag the latest commit? The source archives GitHuB generates for tags are stable, whereas the ones for arbitrary commits aren't.

johnynek pushed a commit that referenced this pull request Oct 3, 2023
@johnynek johnynek mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants