Use attr.output instead of deprecated outputs dict #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stacked on #20, please review that one first. |
johnynek
reviewed
Oct 15, 2022
Backwards compatibility is preserved by wrapping the `jar_jar` rule in a macro that populates the new `output_jar` attribute if the user doesn't set it. The output of a `jar_jar` target can still be referenced as a file target as demonstrated by new tests. In addition, user can now provide a custom name for the output jar.
fmeum
force-pushed
the
prepare-for-bzlmod-2
branch
from
ee75902 to
cbe5a26
Compare
johnynek
approved these changes
Oct 15, 2022
johnynek
reviewed
Oct 15, 2022
| return [ | ||
| JavaInfo( | ||
| output_jar = ctx.outputs.output_jar, | ||
| compile_jar = ctx.outputs.output_jar, |
There was a problem hiding this comment.
another update we should consider is using java_common to run ajar on the output jar to make a compile jar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatibility is preserved by wrapping the
jar_jarrule in amacro that populates the new
output_jarattribute if the user doesn'tset it. The output of a
jar_jartarget can still be referenced as afile target as demonstrated by new tests.
In addition, user can now provide a custom name for the output jar.