Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Ignore declarationDir compiler option #33

Closed
pcj wants to merge 1 commit into from
Closed

Ignore declarationDir compiler option #33

pcj wants to merge 1 commit into from

Conversation

@pcj
Copy link
Member

@pcj pcj commented Sep 9, 2017

Fixes #32

@bazel-io
Copy link
Member

bazel-io commented Sep 9, 2017

Can one of the admins verify this patch?

@alexeagle
Copy link
Contributor

alexeagle commented Sep 9, 2017

How does this solution compare with just overriding the declarationDir in tsconfig.bzl like we do for other options like outDir? I'd rather treat them all the same way.

@pcj
Set declarationDir equal to outDir
e6ca729 
Explicitly set/override the users declarationDir setting to
suppress *.d.ts files from being emitted in a non-predicatable
fashion.

Fixes bazelbuild#32
@pcj
Copy link
Member Author

pcj commented Sep 13, 2017 •
edited
Loading

Apologies for delay, thanks for pointing out tsconfig.bzl. I force pushed a different commit.

It fixes the issue for ts-protoc-gen. In this scenario, we're always emitting a value for declarationDir in the generated tsconfig.json file, which implies that these tsconfig files will be incompatible with older versions of tsc (built before microsoft/TypeScript#7170, Feb 24, 2016). Let me know if you think this will be an issue.

@alexeagle
Copy link
Contributor

alexeagle commented Sep 13, 2017

Thanks!
Yes, we already specify a dependency on TS 2.4 (the tsc-wrapped compiler is tightly coupled with the version of TypeScript)

@alexeagle alexeagle closed this in 2a18977 Sep 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pcj @bazel-io @alexeagle