Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary SwiftBinaryInfo required provider from plugins attribute #1445

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Remove unnecessary SwiftBinaryInfo required provider from plugins attribute #1445

merged 2 commits into from
Oct 25, 2024

Conversation

brentleyjones
Copy link
Collaborator

I incorrectly added this as part of the cherry-pick in 5f6ac77.

@brentleyjones
Lint
5f4738d 
Signed-off-by: Brentley Jones <[email protected]>
@brentleyjones brentleyjones enabled auto-merge (squash) October 25, 2024 13:03
AttilaTheFun
AttilaTheFun approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@AttilaTheFun AttilaTheFun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will make it a lot easier to use pre-built swift compiler plugins.

@brentleyjones brentleyjones merged commit 6d75c15 into master Oct 25, 2024
12 checks passed
@brentleyjones brentleyjones deleted the bj/remove-unnecessary-swiftbinaryinfo-required-provider-from-plugins-attribute branch October 25, 2024 13:07
brentleyjones added a commit that referenced this pull request Oct 25, 2024
@brentleyjones
Remove unnecessary SwiftBinaryInfo required provider from plugins…
fd3c5ac 
… attribute (#1445)

I incorrectly added this as part of the cherry-pick in
5f6ac77.

---------

Signed-off-by: Brentley Jones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttilaTheFun AttilaTheFun AttilaTheFun approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentleyjones @AttilaTheFun