Extract create_swift_module_context and create_{clang,swift}_module_inputs as free functions in the lightweight providers.bzl file, and turn create_swift_info into the initializer callback for SwiftInfo
#1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Oct 7, 2024
…e_inputs` as free functions in the lightweight `providers.bzl` file, and turn `create_swift_info` into the initializer callback for `SwiftInfo`. PiperOrigin-RevId: 493338498
brentleyjones
force-pushed
the
bj/extract-create_swift_module_context-and-create_-clang-swift-_module_inputs-as-free-functions-in-the-lightweight-providers.bzl-file-and-turn-create_swift_info-into-the-initializer-callback-for-swiftinfo
branch
from
216252a to
1afa37b
Compare
…e_inputs` as free functions in the lightweight `providers.bzl` file, and turn `create_swift_info` into the initializer callback for `SwiftInfo` PiperOrigin-RevId: 493338498 (cherry picked from commit d65da7d) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/extract-create_swift_module_context-and-create_-clang-swift-_module_inputs-as-free-functions-in-the-lightweight-providers.bzl-file-and-turn-create_swift_info-into-the-initializer-callback-for-swiftinfo
branch
from
1afa37b to
0bcc690
Compare
luispadron
approved these changes
Oct 9, 2024
brentleyjones
deleted the
bj/extract-create_swift_module_context-and-create_-clang-swift-_module_inputs-as-free-functions-in-the-lightweight-providers.bzl-file-and-turn-create_swift_info-into-the-initializer-callback-for-swiftinfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 493338498
(cherry picked from commit d65da7d)