Move swift_usage_aspect and SwiftUsageInfo from rules_swift into rules_apple
#1223
+0
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
referenced
this pull request
Jun 18, 2024
…rules_apple. With the toolchain information removed, this aspect/provider offers a minimal API. The only client is rules_apple, which uses it to determine if Swift support may need to be bundled at all, so it's better that that single client own it, rather than rules_swift try to provide an API that could serve all possible hypothetical clients. PiperOrigin-RevId: 439577534
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
brentleyjones
changed the title
swift_usage_aspect and SwiftUsageInfo from rules_swift into rules_apple
…rules_apple With the toolchain information removed, this aspect/provider offers a minimal API. The only client is rules_apple, which uses it to determine if Swift support may need to be bundled at all, so it's better that that single client own it, rather than rules_swift try to provide an API that could serve all possible hypothetical clients. PiperOrigin-RevId: 439577534 (cherry picked from commit c24a84a) Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
force-pushed
the
bj/cp-c24a84a128580b5cdd71e647dff01f7a6fe659c4
branch
from
70a8db1 to
105cefc
Compare
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
thii
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the toolchain information removed, this aspect/provider offers a minimal API. The only client is rules_apple, which uses it to determine if Swift support may need to be bundled at all, so it's better that that single client own it, rather than rules_swift try to provide an API that could serve all possible hypothetical clients.
PiperOrigin-RevId: 439577534
(cherry picked from commit c24a84a)