Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply swift.add_target_name_to_output only to outputs that need it #1217

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Apply swift.add_target_name_to_output only to outputs that need it #1217

merged 1 commit into from
Jun 18, 2024

Conversation

brentleyjones
Copy link
Collaborator

In particular, only outputs that need to have the module name as part of the filename.

@brentleyjones brentleyjones force-pushed the bj/fix-target-name branch 2 times, most recently from 573d5de to acdb5e7 Compare June 17, 2024 19:21
brentleyjones
brentleyjones commented Jun 17, 2024
View reviewed changes
Copy link
Collaborator Author

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VFS overlay and explicit module map changed the name to be based on the target (since they don't need to be named after the module). The rest of the changes made the flag apply to fewer output paths, since they already included the target name in them.

test/module_interface_tests.bzl Show resolved Hide resolved
test/module_interface_tests.bzl Show resolved Hide resolved
@brentleyjones brentleyjones force-pushed the bj/fix-target-name branch 2 times, most recently from ce33c61 to 67b5448 Compare June 17, 2024 19:27
@brentleyjones
Apply swift.add_target_name_to_output only to outputs that need it
4f6ecdf 
In particular, only outputs that need to have the module name as part of the filename.

Signed-off-by: Brentley Jones <[email protected]>
@brentleyjones brentleyjones merged commit 970fccd into master Jun 18, 2024
15 checks passed
@brentleyjones brentleyjones deleted the bj/fix-target-name branch June 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luispadron luispadron luispadron approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentleyjones @luispadron