-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform_mappings #1102
Add platform_mappings #1102
Conversation
Blocked on: bazelbuild/bazel#17127 |
in the meantime we can probably either duplicate everything in the platform_mappings file to use the bzlmod identifier, or specify a different |
I tried using @apple_support in
that I can do |
Done |
erm won't we need it to have content to support the other changes you're making in this job? |
Sorry I’m not following. I’m just adding plaform mappings from rules_apple and disabling temporary for bzlmod. What other changes? |
i mean are we going to have to un-disable for bzlmod very soon after you land bazelbuild/bazel#19441? |
Correct. Yesterday I didn’t know it will be fixed so quickly. You can either merge this and I prepare a second pr, or I revert this one back to the old form. Whatever you prefer. |
Replace #1102 with support for bzlmod
that PR is 9 months old, I submitted #1104 with the necessary changes to support bzlmod |
Replace #1102 with support for bzlmod
Replace #1102 with support for bzlmod
This makes it possible to use C++ toolchains with rules_swift.