Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform_mappings #1102

Closed
wants to merge 2 commits into from
Closed

Conversation

comius
Copy link

@comius comius commented Sep 7, 2023

This makes it possible to use C++ toolchains with rules_swift.

@comius
Copy link
Author

comius commented Sep 7, 2023

Blocked on: bazelbuild/bazel#17127

@keith
Copy link
Member

keith commented Sep 7, 2023

in the meantime we can probably either duplicate everything in the platform_mappings file to use the bzlmod identifier, or specify a different --platforms_mappings= with our bzlmod config on CI

@comius
Copy link
Author

comius commented Sep 7, 2023

in the meantime we can probably either duplicate everything in the platform_mappings file to use the bzlmod identifier

I tried using @apple_support in platform_mapping and even removing repo_name from MODULE.bazel and it just doesn't work

or specify a different --platforms_mappings= with our bzlmod config on CI

that I can do

@comius
Copy link
Author

comius commented Sep 7, 2023

Done

@keith
Copy link
Member

keith commented Sep 7, 2023

erm won't we need it to have content to support the other changes you're making in this job?

@comius
Copy link
Author

comius commented Sep 7, 2023

erm won't we need it to have content to support the other changes you're making in this job?

Sorry I’m not following. I’m just adding plaform mappings from rules_apple and disabling temporary for bzlmod. What other changes?

@keith
Copy link
Member

keith commented Sep 7, 2023

i mean are we going to have to un-disable for bzlmod very soon after you land bazelbuild/bazel#19441?

@comius
Copy link
Author

comius commented Sep 7, 2023

i mean are we going to have to un-disable for bzlmod very soon after you land bazelbuild/bazel#19441?

Correct. Yesterday I didn’t know it will be fixed so quickly. You can either merge this and I prepare a second pr, or I revert this one back to the old form. Whatever you prefer.

keith added a commit that referenced this pull request Sep 7, 2023
Replace #1102 with support
for bzlmod
@keith keith mentioned this pull request Sep 7, 2023
@keith
Copy link
Member

keith commented Sep 7, 2023

that PR is 9 months old, I submitted #1104 with the necessary changes to support bzlmod

@keith keith closed this Sep 7, 2023
keith added a commit that referenced this pull request Sep 7, 2023
Replace #1102 with support
for bzlmod
keith added a commit that referenced this pull request Sep 7, 2023
Replace #1102 with support
for bzlmod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants