Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove providers #914

Closed
wants to merge 7 commits into from
Closed

Conversation

ittaiz
Copy link
Member

@ittaiz ittaiz commented Jan 13, 2020

Description

Remove remaining attributes.

This is part of a larger effort of removing all attributes we're returning and return only providers.
Attributes were either:

  1. Moved to DefaultInfo provider
  2. Removed because they were redundant (pre phases they were needed in internal communication)
  3. Coverage which moved to its own provider

Followup on #913

Motivation

Be Bazel 3.0.0 compliant per this bazel issue and unifying on JavaInfo.

Note that this means the minimum version is 1.1.0 because of a JavaInfo issue that was fixed in 1.1.0 and breaks IJ integration.

@ittaiz
Copy link
Member Author

ittaiz commented Jan 13, 2020

This doesn't complete the task since we need to actually return an array of providers from run_phases but that will also involve changing the phases and their return value and such.
Will happen in followup PR.

BTW, this is based on #913 for ease of review

@ittaiz
Copy link
Member Author

ittaiz commented Jan 13, 2020

fails on linting. Will fix tomorrow

@ittaiz
Copy link
Member Author

ittaiz commented Jan 15, 2020

superseded by #916 (same content, more accurate name, branch name and git history)

@ittaiz ittaiz closed this Jan 15, 2020
@ittaiz ittaiz deleted the remove_providers branch January 15, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants