Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incorrect Scalac options and prevent printing ScalacWorker stacktraces #1606

Merged
merged 8 commits into from
Sep 9, 2024
Merged

Handle incorrect Scalac options and prevent printing ScalacWorker stacktraces #1606

merged 8 commits into from
Sep 9, 2024

Commits on Aug 30, 2024

  1. Improve handling of invalid settings passed to Scala compiler. Throw … 

    …known exception instead of allowing to None.get (Scala3) or NullPointerException (Scala2)
    @WojciechMazur
    WojciechMazur committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8172568 View commit details
    Browse the repository at this point in the history

  2. Prevent printing stack trace of ScalacInvoker on known compilation er… 

    …rors
    @WojciechMazur
    WojciechMazur committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3f0e5ba View commit details
    Browse the repository at this point in the history

  3. Run reporter.flush in Scala3

    @WojciechMazur
    WojciechMazur committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    9f352e9 View commit details
    Browse the repository at this point in the history

  4. Restore previous error messages

    @WojciechMazur
    WojciechMazur committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    90766b4 View commit details
    Browse the repository at this point in the history

  5. Addi tests to ensure corect error message and no stack traces are shown

    @WojciechMazur
    WojciechMazur committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d4f20b9 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Remove unused code from test_invalid_scalacopts.sh

    @WojciechMazur
    WojciechMazur committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    74d0759 View commit details
    Browse the repository at this point in the history

  2. Print exception message only once. Previously printed in both e.getMe… 

    …ssage and e.printStackTrace
    @WojciechMazur
    WojciechMazur committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    585ebf4 View commit details
    Browse the repository at this point in the history

  3. Ident with spaces instead of tabs

    @WojciechMazur
    WojciechMazur committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    772a05c View commit details
    Browse the repository at this point in the history