fix: dangerous_test_thirdparty_version.sh

[tanishiking]

Description

CONTRIBUTING.md says we should run ./dangerous_test_thirdparty_version.sh if we change in third-party, but the script fails with the following error.

Log:

sed: can't read : No such file or directory
Loading:
Loading: 0 packages loaded
ERROR: Traceback (most recent call last):
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/WORKSPACE", line 29, column 19, in <toplevel>
                scala_repositories(("2.12.10", { "scala_compiler": "cedc3b9c39d215a9a3ffc0cc75a1d784b51e9edc7f13051a1b4ad5ae22cfbc0c","scala_library": "0a57044d10895f8d3dd66ad4286891f607169d948845ac51e17b4c1cf0ab569d","scala_reflect": "56b609e1bab9144fb51525bfa01ccd72028154fc40a58685a1e9adcbe7835730" }))
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/scala/private/macros/scala_repositories.bzl", line 72, column 21, in scala_repositories
                repositories(
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/third_party/repositories/repositories.bzl", line 31, column 37, in repositories
                _scala_maven_import_external(
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/scala/scala_maven_import_external.bzl", line 240, column 30, in scala_maven_import_external
                jvm_maven_import_external(
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/scala/scala_maven_import_external.bzl", line 261, column 44, in jvm_maven_import_external
                jar_urls = _convert_coordinates_to_urls(coordinates, server_urls)
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/scala/scala_maven_import_external.bzl", line 171, column 46, in _convert_coordinates_to_urls
                urls.append(_concat_with_needed_slash(server_url, url_suffix))
        File "/Users/tanishiking/src/github.com/tanishiking/rules_scala/scala/scala_maven_import_external.bzl", line 175, column 18, in _concat_with_needed_slash
                if server_url.endswith("/"):
Error: 'dict' value has no field or method 'endswith'
ERROR: error loading package '': Encountered error while reading extension file 'proto/repositories.bzl': no such package '@rules_proto//proto': error loading package 'external': Could not load //external package
INFO: Elapsed time: 0.460s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
ERROR: Couldn't start the build. Unable to run tests
FAILED: Build did NOT complete successfully (0 packages loaded)
 Test "test_scala_version 2.12.10 cedc3b9c39d215a9a3ffc0cc75a1d784b51e9edc7f13051a1b4ad5ae22cfbc0c 0a57044d10895f8d3dd66ad4286891f607169d948845ac51e17b4c1cf0ab569d 56b609e1bab9144fb51525bfa01ccd72028154fc40a58685a1e9adcbe7835730" failed  (0 sec)

dangerous_test_thirdparty_version.sh modifies scala_repository in WORKSPACE file to switch scala version for testing bazel test //third_party/...,

However, this logic is implemented when scala_config(scala_version=...) was not yet available.

• test implemented at the beginning of 2020 Add a per-scala-version test for dependency analyzer #971
• scala_version is implemented at the end of 2020 Introduce Scala config #1133

this commit changes the test to use scala_version to switch scala_version, which fix the test.

---

However, there're still some issues with this script

• It takes quite a long time to run tests for all Scala versions
• The list of Scala versions are bit old
• This test is still failing for example for 2.12.10
  • (while it passes for default scala version, verified by bazel test //third_party/... running on CI (via test_rules_scala.sh))

Maybe we should update scala_versions in this script, and run only some latest scala versions? Or, should we maintain this test script any longer?

Motivation

#1433
CONTRIBUTING.md suggested running dangerous_test_thirdparty_version.sh when we change third_party code, and I found this test is broken.

[liucijus]

Thanks a lot for looking into this @tanishiking!
I think we can drop tests for versions that are older than we have in repositories

[tanishiking]

I think we can drop tests for versions that are older than we have in repositories

👍 I'll update the script later :)

edit: updated a908088

[tanishiking]

Looks like the test failed for some network reason (maybe), re-run it may fix

[liucijus]

Unfortunately overrides still need to be passed for non default Scala versions

[liucijus]

Overrides are still needed for versions not defined in default Rules Scala repositories. scala_config only selects repository by it's major version, so in case 2.13.7, still 2.13.6 is used as defined in https://github.com/bazelbuild/rules_scala/blob/master/third_party/repositories/scala_2_13.bzl#L3. Unfortunately there is no good way to check the overridden version and report it to the user.

[liucijus]

closing as stale, feel free to reopen