Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace output_jar with output_sources_jar in java_common.pack_sources #1314

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Replace output_jar with output_sources_jar in java_common.pack_sources #1314

merged 1 commit into from
Nov 5, 2021

Conversation

comius
Copy link
Contributor

@comius comius commented Nov 4, 2021

Description

This updates call to java_common.pack_sources according to bazelbuild/bazel#12373

Motivation

Support latest Bazel version.

@google-cla google-cla bot added the cla: yes label Nov 4, 2021
@comius
Copy link
Contributor Author

comius commented Nov 4, 2021

Can I ask for quick review, because there are three downstream projects on Bazel CI failing because of rules_scala.

@liucijus
Copy link
Collaborator

liucijus commented Nov 4, 2021

@comius thanks! Which projects are failing? How can we be aware such failures?

@comius
Copy link
Contributor Author

comius commented Nov 5, 2021

@comius thanks! Which projects are failing? How can we be aware such failures?

The links are below. I'm part of a rotation that checks for failures on projects using newer Bazel versions. Then we either fix them or open issues. Until we have better handling of external dependencies (bzlmod), this seems to be the optimal way of communication.

rules_jvm_external (Scala example)
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2238#03c1f6db-0b9b-4bab-9767-036a407f55a8

rules_docker
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2238#8c4c34d8-a337-40e7-a0d4-661d294b194a

IntelliJ Plugin Aspect
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2238#b4e2a546-5902-483a-888b-1da7baacbadd

@liucijus liucijus merged commit 2894ca2 into bazelbuild:master Nov 5, 2021
eikemeier added a commit to fillmore-labs/value-comparison that referenced this pull request Nov 9, 2021
@eikemeier
Remove workaround, fixed in bazelbuild/rules_scala#1314
707cffe 
Signed-off-by: Oliver Eikemeier <[email protected]>
eikemeier added a commit to fillmore-labs/kafka-sensors that referenced this pull request Nov 10, 2021
@eikemeier
Use Protobuf from main repository, remove scala workaround
a109a04 
- protocolbuffers/protobuf#9195 merged
- fixed in bazelbuild/rules_scala#1314

Signed-off-by: Oliver Eikemeier <[email protected]>
@wiwa wiwa mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liucijus liucijus liucijus approved these changes

@simuons simuons Awaiting requested review from simuons simuons is a code owner

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comius @liucijus