Skip to content

Not generating CcInfo when out_binary is True #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfarrugi merged 1 commit into from
Oct 15, 2020
Merged

Not generating CcInfo when out_binary is True #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/private/rustc.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ def establish_cc_info(ctx, crate_info, toolchain, cc_toolchain, feature_configur
list: A list containing the CcInfo provider
"""

if crate_info.is_test or crate_info.type not in ("staticlib", "cdylib"):
if crate_info.is_test or crate_info.type not in ("staticlib", "cdylib") or getattr(ctx.attr, "out_binary", False):
return []

if crate_info.type == "staticlib":
Expand Down