Avoid prematurely turning srcs into a depset before rustc_compile_action #3646
+37
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
srcs-depset
branch
3 times, most recently
from
7336c3c to
552f702
Compare
UebelAndre
requested changes
Oct 3, 2025
| crate_info.type, | ||
| ctx.label.name, | ||
| formatted_version, | ||
| len(crate_info.srcs.to_list()), |
There was a problem hiding this comment.
Could this be the source of the performance issues? I would rather delete this logging than make an api change.
There was a problem hiding this comment.
yep, exactly. I'm happy to delete this logging, but FWIW I think the API change is only to private functions; the CrateInfo provider still carries a depset
UebelAndre
approved these changes
Oct 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.