Streamline deps handling in collect_deps #3645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
transform-deps
branch
from
9ec8687 to
6720e0c
Compare
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 6, 2025
No functional changes intended. This adapts protobuf-rust for bazelbuild/rules_rust#3645. PiperOrigin-RevId: 815676249
copybara-service bot
pushed a commit
to protocolbuffers/protobuf
that referenced
this pull request
Oct 6, 2025
No functional changes intended. This adapts protobuf-rust for bazelbuild/rules_rust#3645. PiperOrigin-RevId: 815710367
copybara-service bot
pushed a commit
to google/crubit
that referenced
this pull request
Oct 7, 2025
No functional changes intended. This adapts Crubit for bazelbuild/rules_rust#3645. PiperOrigin-RevId: 816158847 Change-Id: I1b95ba97784cee806f3c9238ea0a59d544cd1f2a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already call
transform_depsin all cases upstream, so we can't end up with Targets here anymore.Before:
After:
