cc works for non-absolute-path toolchains #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
requested review from
acmcarther,
damienmg and
mfarrugi
as code owners
Collaborator
Author
|
I have an example to add to examples which fails without this PR, but it also depends on a second PR I'm about to open. |
damienmg
approved these changes
Jun 17, 2020
dfreese
reviewed
Jun 17, 2020
Bring along the files, and make sure to absolut-ise the CC path. Also, add in the env vars required by the linker, because these are required for proper toolchain detection on the default OSX cc_toolchain.
illicitonion
force-pushed
the
cc-toolchain
branch
from
a40a010 to
b1d16ac
Compare
Collaborator
Author
|
Rebased on the now merged #347 |
dfreese
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring along the files, and make sure to absolut-ise the CC path.
Also, add in the env vars required by the linker, because these are
required for proper toolchain detection on the default OSX cc_toolchain.