Update runfiles to work with directory embedded manifests #3399
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Apr 8, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
#3399 changed the behavior of runfiles. Due to this change a few cases no longer work with `bazel run` that did work before. I tried to create a more complex runfiles example since rules_rust does not have anyone yet + we can use it for discussing what should be the correct behavior. ```shell # Everything with bazel test still works bazel test //... # bazel run no longer works for all cases that work with bazel test bazel run //pkg_a:pkg_a_binary bazel run //pkg_b:pkg_b_binary ``` I added a comment to the few cases that still work with `bazel test` but no longer work with `bazel run`. In particular, this happens when requesting a folder through runfiles instead of an individual file. Co-authored-by: UebelAndre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ability to use runfiles in scenarios where a runfiles directory is created but all it contains is a
MANIFESTfile.This matches the behavior of: