Introduce @rules_testing for Starlark tests #2480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidefield
changed the title
tidefield
force-pushed
the
test-for-bindgen-cc-linkopt
branch
from
f074e98 to
5802697
Compare
tidefield
force-pushed
the
test-for-bindgen-cc-linkopt
branch
from
5802697 to
d641b9e
Compare
UebelAndre
approved these changes
Feb 18, 2024
Collaborator
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Seems totally fine to me! I think if we want to introduce this it'd be good to do so in a change that converts more so we can get a better sense of the practical improvement the new framework offers to the repo.
Contributor
Author
That's a good idea. I'll hold on to this PR until I convert a few more tests to surface the differences more clearly. |
tidefield
force-pushed
the
test-for-bindgen-cc-linkopt
branch
from
978bb3d to
2211293
Compare
Contributor
Author
|
Since I need to use |
qtica
added a commit
to qtica/rules_rust
that referenced
this pull request
Apr 1, 2024
This is a follow-up PR of bazelbuild#2422. I'm scoping it to a separate PR to introduce [@rules_testing](https://github.com/bazelbuild/rules_testing) (a new Starlark testing framework). The framework removes a lot of boilerplate code (unncessarily) required when writing analysis tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #2422.
I'm scoping it to a separate PR to introduce @rules_testing (a new Starlark testing framework). The framework removes a lot of boilerplate code (unncessarily) required when writing analysis tests.