Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find instructions for protobuf toolchains from bzlmod #2534

Open
riking opened this issue Feb 29, 2024 · 1 comment
Open

Can't find instructions for protobuf toolchains from bzlmod #2534

riking opened this issue Feb 29, 2024 · 1 comment

Comments

@riking
Copy link

riking commented Feb 29, 2024

The protobuf instructions make no mention of bzlmod: https://bazelbuild.github.io/rules_rust/rust_proto.html

@UebelAndre
Copy link
Collaborator

Most rules_rust maintainers are pretty new to bzlmod. If anyone wants to open a PR adding some docs I think we'd be happy to review and learn 😅

github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
This PR provides documentation of Bazelmod and several code examples
that addresses a number of issues related to Bazelmod.

Preview of the documentation:
https://github.com/marvin-hansen/rules_rust/blob/main/docs/crate_universe_bzlmod.md

First and foremost it paves the way for a meaningful update the Bazelmod
documentation that references these and existing code examples. This
touches at least the following issues:
* #2670
* #2181


The compile_opt example addresses or resolves:
*  #515
* #2701

The musl_cross_compilling example addresses or resolves
* #390 
* #276

The oci_container does not relate to any open issue, 
although the tokio example in it gives a nice end to end example so 
this definitely helps those looking for something non-trivial.

The proto example addresses or resolves:
*  #2668
*  #302
* #2534
* Possibly a few more if I were to search longer

Formalities
* I've signed the CLA
* I've signed all commits

---------

Signed-off-by: Marvin Hansen <[email protected]>
Co-authored-by: Daniel Wagner-Hall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants