Update runfiles lib #982
Merged
Update runfiles lib #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexeagle This is the first commit with changes backported (?) from Bazel. I will start adding the Bzlmod changes as follow-ups. |
|
Is there a canonical way to format Python files? The runfiles library differs from the Bazel Core one in this regard and I would like to stay consistent with the formatting style used in this repo. |
|
You can install pre-commit.com and run 'pre-commit install' for our typical flow. It just uses black and there's no CI enforcement IIRC |
alexeagle
approved these changes
Jan 11, 2023
rickeylev
approved these changes
Jan 11, 2023
Cherry-picks a fix added to the Bazel version of the runfiles library in bazelbuild/bazel@486d153
fmeum
force-pushed
the
update-runfiles-lib
branch
from
18dc177
to
b220689
Compare
|
I ran the formatters. |
|
Thanks! |
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
* runfiles: Find runfiles in directories that are themselves runfiles Cherry-picks a fix added to the Bazel version of the runfiles library in bazelbuild/bazel@486d153 * runfiles: Add tests from Bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
rules_python's runfiles library is affected by bazelbuild/bazel#14336, which has been fixed upstream.
What is the new behavior?
rules_python's version of the runfiles library contains bazelbuild/bazel@486d153
Does this PR introduce a breaking change?
Other information
Also adds the tests contained in the Bazel repo.