Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Bzlmod for managing external dependencies #1469

Closed
meteorcloudy opened this issue Oct 6, 2023 · 4 comments · Fixed by #1507
Closed

Migrate to Bzlmod for managing external dependencies #1469

meteorcloudy opened this issue Oct 6, 2023 · 4 comments · Fixed by #1507
Assignees
@rickeylev
Milestone
Bzlmod GA

Comments

@meteorcloudy
Copy link
Member

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check bazelbuild/bazel#18958
@meteorcloudy meteorcloudy mentioned this issue Oct 6, 2023
Closed
@meteorcloudy
Copy link
Member Author

Some tests are still failing with Bzlmod enabled:
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3352#018af628-22bd-468d-8813-0356ebe78c86

meteorcloudy added a commit that referenced this issue Oct 6, 2023
@meteorcloudy
Disable Bzlmod explicitly in .bazelrc
ed871f2 
This will help make sure Bazel Downstream Pipeline is green after enabling Bzlmod at Bazel@HEAD

See bazelbuild/bazel#18958 (comment)

#1469
@meteorcloudy meteorcloudy mentioned this issue Oct 6, 2023
Merged
@rickeylev
Copy link
Collaborator

posterity: From a cursory look, I get the impression the cause is some tests aren't going through the runfiles apis, so end up not being aware of repo-remapping.

@aignas aignas added this to the Bzlmod GA milestone Oct 9, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 10, 2023
@meteorcloudy
Disable Bzlmod explicitly in .bazelrc (#1470)
5b529ff 
This will help make sure [Bazel Downstream
Pipeline](https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md)
is green after enabling Bzlmod at Bazel@HEAD

See
bazelbuild/bazel#18958 (comment)

Related issue: #1469
rickeylev added a commit to rickeylev/rules_python that referenced this issue Oct 10, 2023
@rickeylev
test(bzlmod): Make some tests bzlmod compatible
d92ca7d 
A few tests weren't compatible with bzlmod, so would fail when it was
enabled. The various causes and fixes are:

* Under bzlmod, `runfiles.CurrentRepository()` returns the empty string
  for the main repository. To fix, an environment variable is used to
  tell the test whether bzlmod is enabled or not.

* Accessing data files through `TEST_SRCDIR` directly is error-prone
  under bzlmod because the directory name within runfiles changes from
  the workspace name to `_main`. To fix, use the runfiles libraries,
  which know how to map apparent repo names to the actual directory
  name. In the integration tests, the runfiles library isn't available,
  so just check for the `_main` directory instead.

Work towards bazelbuild#1469
rickeylev added a commit to rickeylev/rules_python that referenced this issue Oct 10, 2023
@rickeylev
test(bzlmod): Make some tests bzlmod compatible
13b7067 
A few tests weren't compatible with bzlmod, so would fail when it was
enabled. The various causes and fixes are:

* Under bzlmod, `runfiles.CurrentRepository()` returns the empty string
  for the main repository. To fix, an environment variable is used to
  tell the test whether bzlmod is enabled or not.

* Accessing data files through `TEST_SRCDIR` directly is error-prone
  under bzlmod because the directory name within runfiles changes from
  the workspace name to `_main`. To fix, use the runfiles libraries,
  which know how to map apparent repo names to the actual directory
  name. In the integration tests, the runfiles library isn't available,
  so just check for the `_main` directory instead.

Work towards bazelbuild#1469
rickeylev added a commit to rickeylev/rules_python that referenced this issue Oct 10, 2023
@rickeylev
test(bzlmod): Make some tests bzlmod compatible
b6f6897 
A few tests weren't compatible with bzlmod, so would fail when it was
enabled. The various causes and fixes are:

* Under bzlmod, `runfiles.CurrentRepository()` returns the empty string
  for the main repository. To fix, an environment variable is used to
  tell the test whether bzlmod is enabled or not.

* Accessing data files through `TEST_SRCDIR` directly is error-prone
  under bzlmod because the directory name within runfiles changes from
  the workspace name to `_main`. To fix, use the runfiles libraries,
  which know how to map apparent repo names to the actual directory
  name. In the integration tests, the runfiles library isn't available,
  so just check for the `_main` directory instead.

Work towards bazelbuild#1469
@rickeylev rickeylev mentioned this issue Oct 10, 2023
Merged
@rickeylev rickeylev self-assigned this Oct 10, 2023
@rickeylev
Copy link
Collaborator

PR #1482 out to fix this. It's as I thought -- the runfiles directory changing to _main broke various assumptions.

rickeylev added a commit to rickeylev/rules_python that referenced this issue Oct 11, 2023
@rickeylev
test(bzlmod): Make some tests bzlmod compatible
bf03733 
A few tests weren't compatible with bzlmod, so would fail when it was
enabled. The various causes and fixes are:

* Under bzlmod, `runfiles.CurrentRepository()` returns the empty string
  for the main repository. To fix, an environment variable is used to
  tell the test whether bzlmod is enabled or not.

* Accessing data files through `TEST_SRCDIR` directly is error-prone
  under bzlmod because the directory name within runfiles changes from
  the workspace name to `_main`. To fix, use the runfiles libraries,
  which know how to map apparent repo names to the actual directory
  name. In the integration tests, the runfiles library isn't available,
  so just check for the `_main` directory instead.

Work towards bazelbuild#1469
github-merge-queue bot pushed a commit that referenced this issue Oct 11, 2023
@rickeylev
test(bzlmod): Make some tests bzlmod compatible with Bazel@HEAD (#1482)
cf3cdc1 
A few tests weren't compatible with bzlmod, so would fail when it was
enabled. The various causes and fixes are:

* Under bzlmod, `runfiles.CurrentRepository()` returns the empty string
for the main repository. To fix, an environment variable is used to tell
the test whether bzlmod is enabled or not.

* Accessing data files through `TEST_SRCDIR` directly is error-prone
under bzlmod because the directory name within runfiles changes from the
workspace name to `_main`. To fix, use the runfiles libraries, which
know how to map apparent repo names to the actual directory name. In the
integration tests, the runfiles library isn't available, so just check
for the `_main` directory instead.

Work towards #1469
@rickeylev
Copy link
Collaborator

1482 is merged, so this should be fixed now

@aignas aignas reopened this Oct 18, 2023
@aignas aignas mentioned this issue Oct 18, 2023
Merged
aignas added a commit to aignas/rules_python that referenced this issue Oct 18, 2023
@aignas
test(bzlmod): support toolchain tests on bzlmod
d89376d 
This makes the necessary changes to the toolchains acceptance tests
and also moves the tests to the `//tests` directory as this is the
current convention.

Fixes bazelbuild#1469.
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2023
@aignas
test(bzlmod): support toolchain tests on bzlmod (#1507)
baad5fb 
This makes the necessary changes to the toolchains acceptance tests
and also moves the tests to the `//tests` directory as this is the
current convention.

Fixes #1469.
Fixes #1496.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickeylev rickeylev

Labels
None yet
Projects
None yet
Milestone
Bzlmod GA
Development

Successfully merging a pull request may close this issue.

test(bzlmod): support toolchain tests on bzlmod aignas/rules_python
3 participants
@aignas @meteorcloudy @rickeylev