Skip to content

Commit

Permalink
test: Set mac platform for test_mac_requires_darwin_for_execution (#1179
Browse files Browse the repository at this point in the history
)

This makes the test pass on Bazel built from head. The failure appears
due to not forcing the test to a Mac platform, so the underlying logic
in `py_test` to detect the Mac platform fails and doesn't add the
ExecutionInfo with the necessary info.

Work towards bazelbuild/bazel/issues/18170
  • Loading branch information
rickeylev authored Apr 26, 2023
1 parent ba2a903 commit fb6f49f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/build_defs/python/tests/py_test/py_test_tests.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _test_mac_requires_darwin_for_execution(name, config):
config_settings = {
"//command_line_option:cpu": "darwin_x86_64",
"//command_line_option:crosstool_top": "@rules_python//tools/build_defs/python/tests:cc_toolchain_suite",
#"//command_line_option:platforms": "@rules_python//tools/build_defs/python/tests:mac",
"//command_line_option:platforms": "@rules_python//tools/build_defs/python/tests:mac",
},
)

Expand Down

0 comments on commit fb6f49f

Please sign in to comment.