Skip to content

Commit

Permalink
tests: Set linux platform for test_non_mac_doesnt_require_darwin_for_…
Browse files Browse the repository at this point in the history
…execution (#1183)

This is the inverse test of the one testing for the mac platform. As
before, the line forcing the platform to a non-mac platform was
commented out, which meant, when a mac host built it, it would build the
underlying target for Mac, which violated the test's assumptions.

Work towards bazelbuild/bazel/issues/18170

Fixes #1185
  • Loading branch information
rickeylev authored Apr 28, 2023
1 parent 548ced5 commit ce74914
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/build_defs/python/tests/py_test/py_test_tests.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def _test_non_mac_doesnt_require_darwin_for_execution(name, config):
config_settings = {
"//command_line_option:cpu": "k8",
"//command_line_option:crosstool_top": "@rules_python//tools/build_defs/python/tests:cc_toolchain_suite",
#"//command_line_option:platforms": "@rules_python//tools/build_defs/python/tests:linux",
"//command_line_option:platforms": "@rules_python//tools/build_defs/python/tests:linux",
},
)

Expand Down

0 comments on commit ce74914

Please sign in to comment.