-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 release #869
Merged
Merged
1.0 release #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
approved these changes
Jun 3, 2024
@aiuto Are you planning to update latest in BCR? |
I'm sort of stuck on a merge there. I have not figured out a reasonable way
to have bzlmod ignore the compatibility level loop between ***@***.***
depending (transitively) on rules_proto, where all versions depend on
rules_pkg at level 1.
Updating rules_proto is obviously wrong in 2 ways. It can't work until
rules_pkg is already added. It puts the change burden in the wrong repo.
Doing a special MODULE.bazel that hard specified rules_proto might work.
But that feels wrong too. I don't care what version of proto you get. User
workspace should win, followed by tools I depend directly on. It is also
tedious, because the bcr tests make sure the module.bazel inside the
tarball and given are identical. Which means a dummy release of rules_pkg
for each test. That is ugly.
I filed bugs about the difficulty of updating a compatibilty level for any
widely used module. I just ran out of time to beat my head against
something that is probably better fixed with a bazel flag to not care about
version conflicts and a fix to the bcr submit process.
…On Fri, Jun 21, 2024 at 2:03 AM Mike Kelly ***@***.***> wrote:
@aiuto <https://github.com/aiuto> Are you planning to update latest in
BCR?
—
Reply to this email directly, view it on GitHub
<#869 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC22ZWMCRUJTQS6PCX46RILZIO63NAVCNFSM6AAAAABIW5GYUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBSGA3DENJTGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
@tonyaiuto If the compatibility level is causing so much pain. Perhaps, we should just put it back to the previous value and document the breaking changes. Personally, I think having a BCR entry for a release is more important than signaling breaking changes with the compatibility level. WDYT? |
That may be the path of least resistance. I don't have the time to figure
out a general solution to the transitive loop problem.
I'll send a PR
…On Sun, Jun 23, 2024 at 11:18 AM Chuck Grindel ***@***.***> wrote:
@tonyaiuto <https://github.com/tonyaiuto> If the compatibility level is
causing so much pain. Perhaps, we should just put it back to the previous
value and document the breaking changes. Personally, I think having a BCR
entry for a release is more important than signaling breaking changes with
the compatibility level. WDYT?
—
Reply to this email directly, view it on GitHub
<#869 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHFKYLEVO76MS3MNKILZI3RLTAVCNFSM6AAAAABIW5GYUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGAZTQMJQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just bump the numbers & docs.