Add support for "Epoch" attributes in RPMs #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TvdW
commented
Apr 17, 2024
aiuto
requested changes
Apr 18, 2024
tests/rpm/BUILD
Outdated
| @@ -179,6 +179,7 @@ pkg_rpm( | |||
| architecture = "noarch", | |||
| conflicts = ["not-a-test"], | |||
| description = """pkg_rpm test rpm description""", | |||
| epoch = "1", | |||
There was a problem hiding this comment.
Since this is optional, it should not be in every test case.
tests/rpm/pkg_rpm_basic_test.py
Outdated
| @@ -74,6 +74,7 @@ def test_scriptlet_content(self): | |||
|
|
|||
| def test_basic_headers(self): | |||
| common_fields = { | |||
| "EPOCH": b"1", | |||
There was a problem hiding this comment.
Can you pass in the check for EPOCH to only the samples which add it?
I know that is not the same pattern here, but what is here was hacked up in a hurry. Having version and release the same for everything is not so bad, but we should have split out noarch and group so they can vary by test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #857