Provide more examples for pkg_rpm() #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us be a bit more organized as we add a few more RPM-based examples for rules_pkg.
One we moved this into a subdirectory it was broke because of how it uses rules_pkg as a local repository.
The latter seems to be more the norm, so renaming for consistency and visibility.
This adds a bit more detail the description of the `prebuilt_rpmbuild` example so that someone can understand it a bit more.
This example is essentially the same as the prebuilt_rpmbuild example except that it uses find_system_rpmbuild() to register the local version of `rpmbuild` as the toolchain to use.
This is very similar to the non-bzlmod version except we've replaced the WORKSPACE file with a MODULE.bazel file.
This example uses pkg_rpm() to generate the full rpm in lieu of using a standalone specfile.
|
i wlll look when i get back from vacation
…On Sat, Feb 24, 2024 at 11:32 AM Chuck Grindel ***@***.***> wrote:
***@***.**** approved this pull request.
This looks good to me. I noticed that CI is failing on Windows. @aiuto
<https://github.com/aiuto> is that a flaky test?
—
Reply to this email directly, view it on GitHub
<#823 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC22ZWLBKMSTA5YBFDTPRODYVIBYRAVCNFSM6AAAAABDWAXBAGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJZGUYTSMRWGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Looks like the failure was in pulling the repo, which I assume to be unrelated to my changes. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
pkg_rpm()with no specfile