pkg_deb: allow data.tar.zst #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpkg has officially supported zstandard compression for the data tarball since version 1.21.18, and despite shipping with dpkg version 1.21.1, most .deb packages for Ubuntu 22.04 are also in zst format. While this PR does not do anything to make it easier to create zstd-compressed tarballs, it does make it possible to use them when creating .deb packages. Closes bazelbuild#759
adam-azarchs
requested review from
aiuto,
dannysullivan and
jylinv0
as code owners
|
I'll be OOO until Oct. 14. I can look then.
…On Fri, Oct 6, 2023 at 7:31 AM Adam Azarchs ***@***.***> wrote:
@adam-azarchs <https://github.com/adam-azarchs> requested your review on:
#761 <#761> pkg_deb: allow
data.tar.zst as a code owner.
—
Reply to this email directly, view it on GitHub
<#761 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHCZJVLD3GTOL6QUJI3X56JS3AVCNFSM6AAAAAA5VI2ELGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU3TAOJQGIZTQOI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
aiuto
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dpkg has officially supported zstandard compression for the data tarball since version 1.21.18, and despite shipping with dpkg version 1.21.1, most .deb packages for Ubuntu 22.04 are also in zst format.
While this PR does not do anything to make it easier to create zstd-compressed tarballs, it does make it possible to use them when creating .deb packages.
Closes #759