Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg_tar): properly normalize paths for empty files #760

Merged

Conversation

adam-azarchs
Copy link
Contributor

The directory prefix attribute for a pkg_tar was not being honored for empty files or empty directories.

Closes #758

The directory prefix attribute for a `pkg_tar` was not being honored for
empty files or empty directories.

Closes bazelbuild#758
@adam-azarchs adam-azarchs force-pushed the azarchs/tar_empty_file_normpath branch from bdcc180 to 6f91750 Compare October 6, 2023 05:47
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 1b5710c into bazelbuild:main Oct 6, 2023
1 check passed
@adam-azarchs adam-azarchs deleted the azarchs/tar_empty_file_normpath branch October 6, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_tar: package_dir_file is not applied to pkg_mkdirs entries
2 participants