Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that package_dir also uses package_variables #747

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Document that package_dir also uses package_variables #747

merged 2 commits into from
Sep 5, 2023

Conversation

flode
Copy link
Contributor

@flode flode commented Aug 31, 2023

The pkg_zip and pkg_tar rule already support variable substitution in their package_dir parameter, it was only documented for package_variables so far.

@flode
Document that package_dir also uses package_variables
884b76f 
The pkg_zip and pkg_tar rule already support variable substitution in their
package_dir parameter, it was only documented for package_variables so far.
aiuto
aiuto requested changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to make the docs better.

pkg/private/tar/tar.bzl Outdated Show resolved Hide resolved
@flode flode requested a review from dannysullivan as a code owner September 4, 2023 11:08
aiuto
aiuto approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aiuto aiuto merged commit 19ef5a6 into bazelbuild:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiuto aiuto aiuto approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

@jylinv0 jylinv0 Awaiting requested review from jylinv0 jylinv0 is a code owner

@dannysullivan dannysullivan Awaiting requested review from dannysullivan dannysullivan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flode @aiuto