Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start removing licenses(notice) and replacing with license() #742

Merged
merged 39 commits into from
Apr 16, 2024

Conversation

aiuto
Copy link
Collaborator

@aiuto aiuto commented Aug 23, 2023

licenses() does not do anything.

@aiuto aiuto requested a review from alexeagle as a code owner August 23, 2023 00:56
@aiuto aiuto requested a review from Wyverald August 23, 2023 00:56
@aiuto aiuto changed the title Start removing licenses(notice) Start removing licenses(notice) and replacing with license() Aug 23, 2023
@aiuto
Copy link
Collaborator Author

aiuto commented Sep 3, 2023

@teeler - can we do this?

@aiuto aiuto added the P3 An issue that we are not working on but will review quarterly label Nov 6, 2023
@aiuto
Copy link
Collaborator Author

aiuto commented Nov 6, 2023

Lowered in urgency. It's going to make my imports harder if I do this today.

@aiuto aiuto requested a review from cgrindel as a code owner April 16, 2024 02:35
@aiuto
Copy link
Collaborator Author

aiuto commented Apr 16, 2024

friendly ping from reviewers.
license() is a no-op in Bazel. It is not used in Blaze when applicable_licenses is used.

@aiuto
Copy link
Collaborator Author

aiuto commented Apr 16, 2024

The failing test is unrelated to this. It is that --noenable_bzlmod does not work with bazel at head, and bazelci is ignoreing the explicit bazel version.

@aiuto aiuto merged commit 626de3a into bazelbuild:main Apr 16, 2024
1 of 2 checks passed
@aiuto aiuto deleted the lic branch April 16, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 An issue that we are not working on but will review quarterly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants