Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog attribute to pkg_deb #725

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

k0walik
Copy link
Contributor

@k0walik k0walik commented Aug 11, 2023

Allow passing changelog file to pkg_deb rule.
This addresses #696 issue.

  Allow passing changelog file to pkg_deb rule
@k0walik
Copy link
Contributor Author

k0walik commented Aug 11, 2023

The open question is if we want to propagate content of the changelog file to generated .changes file (see make_deb.py). According to Debian documentation the Changes field is usually extracted from the changelog file. Thoughts?

@aiuto
Copy link
Collaborator

aiuto commented Aug 14, 2023

It should not automatically propagate to the .changes file. That choice should be up to each target. Personally, I would never put the raw changelog into a binary distribution anyway.

@aiuto aiuto merged commit d897540 into bazelbuild:main Aug 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants